Skip to content

Catch the error from a client disconnect due to stalled response #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FranzBusch merged 2 commits into from
Mar 6, 2026
Merged

Catch the error from a client disconnect due to stalled response #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb5718b
Catch the error from a client disconnect due to stalled response
xbhatnag Mar 5, 2026
2d44a0e
swift-format
xbhatnag Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions Sources/HTTPClientConformance/HTTPServerForTesting/TestHTTPServer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,23 +329,31 @@ func serve(server: NIOHTTPServer) async throws {
return nil
}
case "/stall":
// Wait for an hour (effectively never giving an answer)
try await Task.sleep(for: .seconds(60 * 60))
assertionFailure("Not expected to complete hour-long wait")
do {
// Wait for an hour (effectively never giving an answer)
try await Task.sleep(for: .seconds(60 * 60))
assertionFailure("Not expected to complete hour-long wait")
} catch {
// It is okay for the client to give up on the connection due to the stall.
}
case "/stall_body":
// Send headers and partial body
let responseBodyAndTrailers = try await responseSender.send(.init(status: .ok))

try await responseBodyAndTrailers.produceAndConclude { responseBody in
var responseBody = responseBody
try await responseBody.write([UInt8](repeating: UInt8(ascii: "A"), count: 1000).span)
do {
try await responseBodyAndTrailers.produceAndConclude { responseBody in
var responseBody = responseBody
try await responseBody.write([UInt8](repeating: UInt8(ascii: "A"), count: 1000).span)

// Wait for an hour (effectively never giving an answer)
try await Task.sleep(for: .seconds(60 * 60))
// Wait for an hour (effectively never giving an answer)
try await Task.sleep(for: .seconds(60 * 60))

assertionFailure("Not expected to complete hour-long wait")
assertionFailure("Not expected to complete hour-long wait")

return nil
return nil
}
} catch {
// It is okay for the client to give up on the connection due to the stall.
}
case "/1mb_body":
let responseBodyAndTrailers = try await responseSender.send(.init(status: .ok))
Expand Down
Loading