Catch the error from a client disconnect due to stalled response#126
Merged
FranzBusch merged 2 commits intomainfrom Mar 6, 2026
Merged
Catch the error from a client disconnect due to stalled response#126FranzBusch merged 2 commits intomainfrom
FranzBusch merged 2 commits intomainfrom
Conversation
Collaborator
Author
|
@gjcairo can you help investigate why the server behaves differently on Mac vs Linux? |
guoye-zhang
approved these changes
Mar 5, 2026
FranzBusch
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #123 was hanging on presubmit for AHC conformance tests on Linux.
This was root-caused to an issue with
testCancelPreHeadersandtestCancelPreBody.Here is the sequence of events:
testCancelPreBodycancels the task making the request to/stall_body.try await Task.sleep(..)due to client disconnection.NIOHTTPServer.Note: This issue does not happen when the tests run under Mac + AHC. Further investigation into possible server-side issues is warranted here. Why does it only occur for Linux and not Mac?
Modifications
Instead of letting the error propagate up into the server, the handler swallows any errors from the
/stalland/stall_bodyendpoints.Result
The AHC conformance tests in #123 now pass under Linux.
Test Plan
N/A. This fixes a broken test.