Avoid using pouchdb-server in CI and local tests#9205
Merged
janl merged 2 commits intoapache:masterfrom Mar 26, 2026
Merged
Conversation
Destroying databases is flaky in pouchdb-server
Contributor
Author
|
CI is now consistently green with these changes, but I can’t get that one pending check to resolve itself ( I assume the reason for this is that we changed one of the CI commands: |
4fa41fb to
8c0980b
Compare
janl
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroying databases is flaky in pouchdb-server. This PR supersedes #9204
Overview
PouchDB integration tests were very flaky, with random timeouts. We (NH) identified this being caused by an issue with
pouchdb-server, where thedestroy()method used to clean up test DBs didn’t actually remove the test databases. The tests no longer seem to time out when using a CouchDB viaCOUCH_HOSTinstead ofpouchdb-server. This PR changes the CI setup so we can verify this assumption by running the CI repeatedly.We moved the node PERF tests out into their own
nodejs-perfJob , since our changes conflicted with that particular bit of thenodejob.In addition: updated
TESTING.mdto reflect thatCOUCH_HOSTis basically mandatory at this point in time. Also removed references to Admin Party, added a ToC and made a bunch of other small improvements.Testing recommendations
We want to re-run the test suite multiple times to se whether the timeouts are resolved, and if so, submit this as a fix.
Checklist
docsfolder