ci: speed up CI by installing fewer playwright deps#9207
Open
espy wants to merge 1 commit intoapache:masterfrom
Open
ci: speed up CI by installing fewer playwright deps#9207espy wants to merge 1 commit intoapache:masterfrom
espy wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
run-test.shdoesnpx playwright install --with-deps "$CLIENT", which is quite slow on GH CI. This PR is an attempt to avoid--with-depsand selectively install only the few things Playwright actually needs, according to this guide.Testing recommendations
Run the CI on this PR and compare it to the CI runs for #9205, this one should be faster, especially on the
browser-adaptertests, some of which (eg. this one) take over 5 minutes each (sometimes much more), most of which is installing Playwright deps.Specifically, compare the Usage pages of the two runs, those show the cumulative time of all runs at the bottom.
Checklist
docsfolder