Skip to content

[common] Fix wrong binary ordering due to signed subtraction #8237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnavBalyan wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −1
Open

[common] Fix wrong binary ordering due to signed subtraction #8237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paimon-common/src/main/java/org/apache/paimon/predicate/CompareUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public static int compareLiteral(DataType type, Object v1, Object v2) {

private static int compare(byte[] first, byte[] second) {
for (int x = 0; x < min(first.length, second.length); x++) {
int cmp = first[x] - second[x];
int cmp = Byte.toUnsignedInt(first[x]) - Byte.toUnsignedInt(second[x]);
if (cmp != 0) {
return cmp;
}
Expand Down
20 changes: 20 additions & 0 deletions paimon-common/src/test/java/org/apache/paimon/predicate/PredicateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,26 @@ public void testEqual() {
assertThat(predicate.negate().orElse(null)).isEqualTo(builder.notEqual(0, 5));
}

@Test
public void testBinaryUnsignedComparison() {
PredicateBuilder builder = new PredicateBuilder(RowType.of(DataTypes.BYTES()));

Predicate greaterThan = builder.greaterThan(0, new byte[] {(byte) 0x7F});
assertThat(greaterThan.test(GenericRow.of((Object) new byte[] {(byte) 0x80}))).isTrue();
assertThat(greaterThan.test(GenericRow.of((Object) new byte[] {(byte) 0x7E}))).isFalse();

Predicate greaterThanLow = builder.greaterThan(0, new byte[] {(byte) 0x01});
assertThat(greaterThanLow.test(GenericRow.of((Object) new byte[] {(byte) 0xFF}))).isTrue();

Predicate lessThan = builder.lessThan(0, new byte[] {(byte) 0x80});
assertThat(lessThan.test(GenericRow.of((Object) new byte[] {(byte) 0x01}))).isTrue();
assertThat(lessThan.test(GenericRow.of((Object) new byte[] {(byte) 0xFF}))).isFalse();

Predicate between = builder.between(0, new byte[] {(byte) 0x70}, new byte[] {(byte) 0x90});
assertThat(between.test(GenericRow.of((Object) new byte[] {(byte) 0x80}))).isTrue();
assertThat(between.test(GenericRow.of((Object) new byte[] {(byte) 0x60}))).isFalse();
}

@Test
public void testEqualNull() {
PredicateBuilder builder = new PredicateBuilder(RowType.of(new IntType()));
Expand Down