Skip to content

[FLINK-39331] Add @Experimental annotation to public Native S3 classes #27833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Samrat002 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

[FLINK-39331] Add @Experimental annotation to public Native S3 classes #27833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...k-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3AFileSystemFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

package org.apache.flink.fs.s3native;

import org.apache.flink.annotation.Experimental;

/**
* Factory for the native S3 file system registered for the {@code s3a://} scheme.
*
Expand All @@ -27,6 +29,7 @@
* <p>All configuration options are the same as for the {@code s3://} scheme. See {@link
* NativeS3FileSystemFactory} for available options.
*/
@Experimental
public class NativeS3AFileSystemFactory extends NativeS3FileSystemFactory {

@Override
Expand Down
2 changes: 2 additions & 0 deletions ...nk-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.apache.flink.fs.s3native;

import org.apache.flink.annotation.Experimental;
import org.apache.flink.configuration.ConfigOption;
import org.apache.flink.configuration.ConfigOptions;
import org.apache.flink.configuration.Configuration;
Expand All @@ -33,6 +34,7 @@
import java.io.IOException;
import java.net.URI;

@Experimental
public class NativeS3FileSystemFactory implements FileSystemFactory {

private static final Logger LOG = LoggerFactory.getLogger(NativeS3FileSystemFactory.class);
Expand Down
2 changes: 2 additions & 0 deletions ...s/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3OutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.apache.flink.fs.s3native;

import org.apache.flink.annotation.Experimental;
import org.apache.flink.core.fs.FSDataOutputStream;

import software.amazon.awssdk.core.sync.RequestBody;
Expand All @@ -42,6 +43,7 @@
* can be safely invoked from another thread (e.g. during task cancellation) per {@link
* org.apache.flink.core.fs.FSDataOutputStream} contract.
*/
@Experimental
Copy link
Contributor

@Izeren Izeren Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

public class NativeS3OutputStream extends FSDataOutputStream {

private static final int BUFFER_SIZE = 64 * 1024;
Expand Down
2 changes: 2 additions & 0 deletions ...ink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/writer/NativeS3Committer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.apache.flink.fs.s3native.writer;

import org.apache.flink.annotation.Experimental;
import org.apache.flink.core.fs.RecoverableFsDataOutputStream;
import org.apache.flink.core.fs.RecoverableWriter;

Expand All @@ -39,6 +40,7 @@
* <p>The "empty parts" check is a defensive measure against programming errors - in normal
* operation, a multipart upload should always have at least one part before committing.
*/
@Experimental
public class NativeS3Committer implements RecoverableFsDataOutputStream.Committer {
Copy link
Contributor

@Izeren Izeren Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this class to be public?


private final NativeS3AccessHelper s3AccessHelper;
Expand Down
2 changes: 2 additions & 0 deletions .../main/java/org/apache/flink/fs/s3native/writer/NativeS3RecoverableFsDataOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

package org.apache.flink.fs.s3native.writer;

import org.apache.flink.annotation.Experimental;
import org.apache.flink.core.fs.RecoverableFsDataOutputStream;
import org.apache.flink.core.fs.RecoverableWriter;
import org.apache.flink.fs.s3native.writer.NativeS3Recoverable.PartETag;
Expand Down Expand Up @@ -50,6 +51,7 @@
* #closeForCommit()}, and {@link #persist()} to ensure safe cleanup of local resources without
* corrupting S3 state.
*/
@Experimental
@NotThreadSafe
public class NativeS3RecoverableFsDataOutputStream extends RecoverableFsDataOutputStream {
Copy link
Contributor

@Izeren Izeren Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same


Expand Down