[FLINK-39331] Add @Experimental annotation to public Native S3 classes#27833
Open
Samrat002 wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39331] Add @Experimental annotation to public Native S3 classes#27833Samrat002 wants to merge 1 commit intoapache:masterfrom
Samrat002 wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
Izeren
reviewed
Mar 26, 2026
Contributor
Izeren
left a comment
Izeren
left a comment
There was a problem hiding this comment.
Thank you for the PR @Samrat002, I wonder if we should rather reduce visibility of the classes than adding experimental annotation to them (except for factories)
| * operation, a multipart upload should always have at least one part before committing. | ||
| */ | ||
| @Experimental | ||
| public class NativeS3Committer implements RecoverableFsDataOutputStream.Committer { |
Contributor
There was a problem hiding this comment.
Do we need this class to be public?
| */ | ||
| @Experimental | ||
| @NotThreadSafe | ||
| public class NativeS3RecoverableFsDataOutputStream extends RecoverableFsDataOutputStream { |
| * can be safely invoked from another thread (e.g. during task cancellation) per {@link | ||
| * org.apache.flink.core.fs.FSDataOutputStream} contract. | ||
| */ | ||
| @Experimental |
Contributor
|
@Samrat002, In addition, should we downgrade: Also, NativeS3RecoverableWriter is marked as @PublicEvolving, and it should be Experimental@ as well |
github-actions
bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Mark the public API classes in flink-s3-fs-native as experimental to signal to users that this feature is still evolving and may undergo changes in future releases.
Brief change log
Mark following public class with
@ExperimentalNativeS3FileSystemFactoryNativeS3AFileSystemFactoryNativeS3OutputStreamNativeS3RecoverableFsDataOutputStreamNativeS3CommitterVerifying this change
Existing UT suffices.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yes (marked as@Experimental)Documentation