set displayName to name by default

[DaanHoogland]

Description

This PR prevents a null display name on VMs (see #8503 (comment))

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (b394b5b) to head (609683c).
⚠️ Report is 84 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...he/cloudstack/api/command/user/vm/UpdateVMCmd.java	0.00%	2 Missing ⚠️
...he/cloudstack/api/command/user/vm/DeployVMCmd.java	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9719      +/-   ##
============================================
+ Coverage     16.23%   16.26%   +0.03%     
- Complexity    13377    13418      +41     
============================================
  Files          5657     5658       +1     
  Lines        498865   499428     +563     
  Branches      60545    60613      +68     
============================================
+ Hits          80991    81233     +242     
- Misses       408843   409146     +303     
- Partials       9031     9049      +18     

Flag	Coverage Δ
uitests	4.03% <ø> (+0.03%)	⬆️
unittests	17.12% <25.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11176

[weizhouapache]

@DaanHoogland
it looks like an UI issue

the API response does have the "displayname" in place. but the name/displayname is not displayed on UI.

as a simple workaround, can we revert #8503 ? @DaanHoogland

[DaanHoogland]

as a simple workaround, can we revert #8503 ? @DaanHoogland

yes, you are right, I'll creat another PR, reapply the changes here, and work on this later.

[weizhouapache]

@blueorangutan ui

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9719 (QA-JID-456)

[harikrishna-patnala]

@DaanHoogland is this ready for review ?

[harikrishna-patnala]

code LGTM.

Note: Currently I see we are already setting the name given in the UI form directly to both name and displayName. This PR is more of code level defaulting.

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sudo87]

clgtm