list VMs by displayname instead of name

[DaanHoogland]

Description

This PR addresses #4654 (comment) TBD

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

in qa

[codecov]

Codecov Report

Attention: Patch coverage is 50.14767% with 844 lines in your changes are missing coverage. Please review.

Project coverage is 30.73%. Comparing base (76aff0f) to head (8cb9dcf).
Report is 25 commits behind head on 4.18.

❗ Current head 8cb9dcf differs from pull request most recent head 36be215. Consider uploading reports for the commit 36be215 to get more accurate results

Files	Patch %	Lines
api/src/main/java/com/cloud/gpu/GPU.java	0.00%	98 Missing ⚠️
...apache/cloudstack/api/response/BucketResponse.java	0.00%	69 Missing ⚠️
...stack/api/command/user/bucket/CreateBucketCmd.java	2.56%	38 Missing ⚠️
...i/response/SecondaryStorageHeuristicsResponse.java	0.00%	34 Missing ⚠️
...nt/resource/consoleproxy/ConsoleProxyResource.java	0.00%	33 Missing ⚠️
...e/cloudstack/api/command/admin/vm/ImportVmCmd.java	3.12%	31 Missing ⚠️
...stack/api/command/user/bucket/UpdateBucketCmd.java	3.84%	25 Missing ⚠️
...ack/api/command/user/snapshot/CopySnapshotCmd.java	51.06%	15 Missing and 8 partials ⚠️
...command/admin/storage/AddObjectStoragePoolCmd.java	40.54%	20 Missing and 2 partials ⚠️
...e/cloudstack/api/response/ObjectStoreResponse.java	9.52%	19 Missing ⚠️
... and 92 more

Additional details and impacted files

@@              Coverage Diff              @@
##               4.18    #8503       +/-   ##
=============================================
+ Coverage     13.12%   30.73%   +17.60%     
- Complexity     9142    33911    +24769     
=============================================
  Files          2720     5341     +2621     
  Lines        257744   374971   +117227     
  Branches      40182    54546    +14364     
=============================================
+ Hits          33839   115242    +81403     
- Misses       219615   244488    +24873     
- Partials       4290    15241    +10951     

Flag	Coverage Δ
simulator-marvin-tests	24.61% <28.05%> (?)
uitests	4.39% <ø> (?)
unit-tests	16.48% <34.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

@DaanHoogland
both ?

[DaanHoogland]

Or not, to be discussed

[DaanHoogland]

@blueorangutan ui

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-263)

[vishesh92]

clgtm

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-265)

[yadvr]

As far as I know that weren't regressions; As part of #7833 since the display and name are the same for most users, having two redundant columns - so one of the two were removed as part of polish idea on #7833: Standardise most resources to show state/status columns right after resource name (wherever applicable) and Remove displayname column in VM list view, add cpu number and memory by default.
@DaanHoogland cc @andrijapanicsb

[yadvr]

I actually prefer name to display name; but I've no objection if everybody agrees with the changes. Historical context: for many resources we've a name and a displayname, which is because CPBM and other portal/layers could refer to a resource by its display name while internally in ACS it could be referred to as name.

[DaanHoogland]

@andrijapanicsb can you give your uncensored input on this?

[DaanHoogland]

ping @andrijapanicsb

[andrijapanicsb]

I did RTFM the whole thing, and the original issue/comments.

LGTM - I think redundancy makes no sense (having both fields), especially since VMs created by UI have identical values for both.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.24%. Comparing base (9d5d4e5) to head (7faa31c).
Report is 29 commits behind head on 4.18.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.18    #8503      +/-   ##
============================================
- Coverage     12.24%   12.24%   -0.01%     
+ Complexity     9291     9290       -1     
============================================
  Files          4698     4698              
  Lines        414259   414259              
  Branches      51377    51765     +388     
============================================
- Hits          50707    50706       -1     
- Misses       357251   357252       +1     
  Partials       6301     6301              

Flag	Coverage Δ
unittests	12.24% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-325)

[kiranchavala]

@blueorangutan ui

[blueorangutan]

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-372)

[kiranchavala]

LGTM, name is changed to displayname

Before

After

[yadvr]

@DaanHoogland is name used for instances when displayname may be empty or not returned by the API? (or perhaps is it handled by the backend API?)

[DaanHoogland]

display name is filled with name is not provides as far as I know, I'll check the code.

[DaanHoogland]

@DaanHoogland is name used for instances when displayname may be empty or not returned by the API? (or perhaps is it handled by the backend API?)

I see no mitigation of this possibility in a generic execution branch. The only path I encounter is

        if (displayName == null) {
            displayName = vm.getDisplayName();
        }

So I created a PR to deal with it : #9719 . I think this is not necessary as I have never seen an empty displayname before, but better safe than sorry ;)