Tony/259 stay logged in

[tonypioneer]

Pull Request Details

What issue does this PR address

• Aligned STAY SIGNED IN and TRY ANOTHER WEBID in a Row().
• Optimised the workflow.

Associated Issue

• This PR relates to issues Align STAY SIGNED IN and TRY ANOTHER WEBID in a Row() #258 and The STAY LOGGED IN widget is not intuitive #259.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Build and run the app.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue Align STAY SIGNED IN and TRY ANOTHER WEBID in a Row() #258
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[gjwgit]

When I untick STAY LOGGED IN and then tap LOGIN I get the browser, but when back to the app it remains on the LoginPage.

solidAuthenticate() => solid_auth.authenticate(https://pods.solidcommunity.au)
[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: NotLoggedInException: Cannot check initialisation flag without logging in
#0      _getPodInitFlagKey (package:solidpod/src/solid/utils/init_helper.dart:61:5)
<asynchronous suspension>
#1      markPodStructureInitialised (package:solidpod/src/solid/utils/init_helper.dart:87:15)
<asynchronous suspension>
#2      SolidLoginAuthHandler.handleLogin (package:solidui/src/widgets/solid_login_auth_handler.dart:327:9)
<asynchronous suspension>
#3      _SolidLoginState.build.performLogin (package:solidui/src/widgets/solid_login.dart:417:7)
<asynchronous suspension>

[tonypioneer]

When I untick STAY LOGGED IN and then tap LOGIN I get the browser, but when back to the app it remains on the LoginPage.

solidAuthenticate() => solid_auth.authenticate(https://pods.solidcommunity.au)
[ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: NotLoggedInException: Cannot check initialisation flag without logging in
#0      _getPodInitFlagKey (package:solidpod/src/solid/utils/init_helper.dart:61:5)
<asynchronous suspension>
#1      markPodStructureInitialised (package:solidpod/src/solid/utils/init_helper.dart:87:15)
<asynchronous suspension>
#2      SolidLoginAuthHandler.handleLogin (package:solidui/src/widgets/solid_login_auth_handler.dart:327:9)
<asynchronous suspension>
#3      _SolidLoginState.build.performLogin (package:solidui/src/widgets/solid_login.dart:417:7)
<asynchronous suspension>

Hi @gjwgit, this issue has been fixed.

[gjwgit]

Tested - working as advertised.