To update tox file for fixing linting failures#13
Merged
ansible-zuul[bot] merged 9 commits intoansible-security:masterfrom Dec 1, 2021
Merged
To update tox file for fixing linting failures#13ansible-zuul[bot] merged 9 commits intoansible-security:masterfrom
ansible-zuul[bot] merged 9 commits intoansible-security:masterfrom
Conversation
Contributor
|
@justjais we should drop the ansible-tox-molecule job for now too. That's likely in project-config |
Contributor
Author
|
@pabelanger ack, and for the PR changes |
Contributor
|
you need to at it to test-requirements.txt eg: https://github.com/ansible-collections/vyos.vyos/blob/main/test-requirements.txt#L1 |
Contributor
Author
|
@pabelanger ah ok, thanks for the swift response |
|
I think the disk space problem comes from the fact you pull the full Ansible distribution, the whole thing is pretty large. |
|
You need to configure yamllint to ignore the .tox directory. e.g: https://github.com/ansible-collections/community.vmware/blob/main/tox.ini#L20 |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ansible-zuul bot
added a commit
that referenced
this pull request
Dec 18, 2021
Changed defaults. Added barnyard pkg var Depends-on: #13 Issue Role defaults point to a defunct S3 bucket causing the role to fail Static entries in playbooks meant that current vars supplied were not enough Resolution defaults/main.yml updated default values created a new var called ids_install_snort_barnyard_pkg tasks/main.yml referenced ``ids_install_snort_barnyard_pkg``` Reviewed-by: Sumit Jaiswal <sjaiswal@redhat.com> Reviewed-by: None <None>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.