Skip to content

Changed defaults. Added barnyard pkg var#12

Merged
ansible-zuul[bot] merged 5 commits intoansible-security:masterfrom
craig-br:role-defaults
Dec 18, 2021
Merged

Changed defaults. Added barnyard pkg var#12
ansible-zuul[bot] merged 5 commits intoansible-security:masterfrom
craig-br:role-defaults

Conversation

@craig-br
Copy link
Contributor

@craig-br craig-br commented Aug 9, 2021

Depends-on: #13

Issue

  • Role defaults point to a defunct S3 bucket causing the role to fail
  • Static entries in playbooks meant that current vars supplied were not enough

Resolution

defaults/main.yml

  • updated default values
  • created a new var called ids_install_snort_barnyard_pkg

tasks/main.yml

  • referenced ``ids_install_snort_barnyard_pkg```

@craig-br
Copy link
Contributor Author

craig-br commented Aug 9, 2021

@justjais . May I please ask you to review. I need it for the security workshop.

@justjais
Copy link
Contributor

@craig-br changes LGTM can you plz fix the linter failures, before we can merge the PR

@justjais
Copy link
Contributor

justjais commented Dec 1, 2021

recheck

1 similar comment
@justjais
Copy link
Contributor

justjais commented Dec 1, 2021

recheck

@justjais justjais added the gate Gate PR in Zuul CI label Dec 18, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 6eda381 into ansible-security:master Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gate Gate PR in Zuul CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants