Skip to content

build: remove redundant Bazel lockfile update workarounds #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Mar 17, 2026
Merged

build: remove redundant Bazel lockfile update workarounds #3553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions renovate-presets/default.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,6 @@
// GENERAL GROUPING & UPDATE BEHAVIOR
// ============================================================================

// Enable 'postUpdateTasks' for changes that effect the BAZEL lockfile or generated files.
// Renovate does not update Bazel lockfile for the time being.
// Workaround for https://github.com/renovatebot/renovate/issues/25557
{
postUpgradeTasks: {
matchManagers: ['bazel', 'bazel-module', 'bazelisk'],
commands: [
'bash -c "git restore .npmrc || true"', // If `.npmrc` doesn't exist, avoid a hard error.
'bazel mod deps --lockfile_mode=update',
],
// This is theory should be `branch` but in some cases this is causing the command not to
// run when in the same branch there are mixtures of update types by different managers.
executionMode: 'update',
},
},

// Enable 'postUpdateTasks' for changes that effect the typescript and pnpm versions.
// This is to ensure that the `MODULE.bazel` is updated with the correct versions.
{
Expand Down
3 changes: 0 additions & 3 deletions tools/sync-all-modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ export BAZEL="$(git rev-parse --show-toplevel)/node_modules/.bin/bazel"

echo "Starting synchronization of all Bazel modules..."

# Update the root lockfile. This is needed for the sync-module-bazel command to work.
"$BAZEL" mod deps --lockfile_mode=update

# Find and store all MODULE.bazel directories
module_dirs=()
while IFS= read -r -d '' module_file; do
Expand Down
Loading