build: remove redundant Bazel lockfile update workarounds#3553
build: remove redundant Bazel lockfile update workarounds#3553alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
Renovate now natively supports updating Bazel lockfiles. This change removes the `postUpgradeTasks` workaround in Renovate presets and a redundant synchronization step in the `sync-all-modules.sh` script that were previously used to manually update Bazel lockfiles.
alan-agius4
added
the
action: blocked
angular-robot
bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes redundant workarounds for Bazel lockfile updates, following Renovate's new native support. The changes in renovate-presets/default.json5 and tools/sync-all-modules.sh are appropriate. I have added a comment to tools/sync-all-modules.sh suggesting further optimizations to improve the script's efficiency by removing additional redundant lockfile update commands.
I am having trouble creating individual review comments. Click here to see my feedback.
tools/sync-all-modules.sh (9-10)
While removing this initial redundant lockfile update is a good optimization, the script still contains other inefficiencies that could be addressed to improve performance and clarity.
- The
sync-module-bazelcommand, called on line 22, already updates the Bazel lockfile. The subsequent call on line 26 is therefore redundant and can be removed. - The loop on lines 32-38 repeatedly runs
bazel mod deps --lockfile_mode=update. Since this command operates on the workspace root regardless of the directory it's run from, this loop can be replaced by a single call after the first loop completes.
Addressing these points would make the script more efficient.
alan-agius4
added
action: merge
| ) | ||
|
|
||
| # Update the root lockfile. This is needed for the sync-module-bazel command to work due to circular dependencies. | ||
| "$BAZEL" mod deps --lockfile_mode=update |
There was a problem hiding this comment.
Will renovate not find all of the bazel lockfiles?
There was a problem hiding this comment.
Due to circular dependencies, we still need to run this when we update the TS version from the package.json
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
Renovate now natively supports updating Bazel lockfiles.
This change removes the
postUpgradeTasksworkaround in Renovate presets and a redundant synchronization step in thesync-all-modules.shscript that were previously used to manually update Bazel lockfiles.