Skip to content

fix(native-federation): fix i18n translation for lazy chunks and Windows #1055 #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aukevanoost merged 1 commit into from
Feb 9, 2026
+5 −9
Merged

fix(native-federation): fix i18n translation for lazy chunks and Windows #1055 #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions libs/native-federation/src/utils/i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,18 @@ export async function translateFederationArtefacts(

const translationOutPath = path.join(outputPath, 'browser', '{{LOCALE}}');

const federationFiles = [
...federationResult.shared.map((s) => s.outFileName),
...federationResult.exposes.map((e) => e.outFileName),
];

// Here, we use a glob with an exhaustive list i/o `"*.js"`
// to improve performance
const sourcePattern = '{' + federationFiles.join(',') + '}';
// Use *.js to translate ALL JS files, including lazy-loaded chunks
// that may contain $localize markers from exposed modules
const sourcePattern = '*.js';

const sourceLocalePath = path.join(outputPath, 'browser', sourceLocale);

const localizeTranslate = path.resolve(
'node_modules/.bin/localize-translate',
);

const cmd = `${localizeTranslate} -r ${sourceLocalePath} -s "${sourcePattern}" -t ${translationFiles} -o ${translationOutPath} --target-locales ${targetLocales} -l ${sourceLocale}`;
// Quote paths to handle spaces (Windows compatibility)
const cmd = `"${localizeTranslate}" -r "${sourceLocalePath}" -s "${sourcePattern}" -t ${translationFiles} -o "${translationOutPath}" --target-locales ${targetLocales} -l ${sourceLocale}`;

ensureDistFolders(locales, outputPath);
copyRemoteEntry(locales, outputPath, sourceLocalePath);
Expand Down