fix(native-federation): fix i18n translation for lazy chunks and Windows #1055 #1057
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows paths ## Problem Two issues with `translateFederationArtefacts`: 1. **Windows paths with spaces** break the `localize-translate` command 2. **Lazy-loaded chunks** containing `$localize` markers are not translated (only federation artifacts in `shared`/`exposes` were processed) ## Solution - Quote all paths in the command for Windows compatibility - Use `*.js` pattern to translate ALL JS files, including lazy chunks Fixes angular-architects#1055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Two issues with
translateFederationArtefacts:localize-translatecommand$localizemarkers are not translated (only federation artifacts inshared/exposeswere processed)Solution
*.jspattern to translate ALL JS files, including lazy chunksFixes #1055