Add DualModePolicyConfig, simplify inference CLI#80
Open
brentyi wants to merge 2 commits intoamazon-far:mainfrom
Open
Add DualModePolicyConfig, simplify inference CLI#80brentyi wants to merge 2 commits intoamazon-far:mainfrom
DualModePolicyConfig, simplify inference CLI#80brentyi wants to merge 2 commits intoamazon-far:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #73, which adds a dual policy inference mode that can be quickly switched between.
In #73, this was implemented by:
secondary: InferenceConfigfield to theInferenceConfigclass:tyroparser is used to override config defaults.Two problems here:
inference_configthere's ainference_config.secondary, but that secondary can also have a secondary:inference_config.secondary.secondary.argparseparsing logic adds complexity.This PR:
DualModePolicyConfigclass with two fields,primary: InferenceConfigandsecondary: InferenceConfig. I think this is clearer.DualModePolicyConfiginstead ofInferenceConfig. We could add an automatic cast / compatibility shim if this is a problem.DualModePolicyConfigto re-implement the secondary config selection logic usingtyro.inference:g1-29dof-loconow refer to a (primary, secondary) inference config pair. The default secondary can be overridden with eithernoneor another inference config.--secondary noneis nowsecondary:none.--secondary-preset g1-29dof-wbtis nowsecondary:g1-29dof-wbt.@tomasz-lewicki @carlosferrazza