Migrate to KSP2 #379
Open
Migrate to KSP2 #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add namespace. - Configure java version. - Update Gradle.
Use the configureKsp function to initialize KSP.
KAPT does not add the parent class while KSP does
KSP shows values in different order than KAPT and it makes some tests to fail. Ensure we have the same output for all processors.
Type elements can become invalid after PSI changes so it's safer to query them when we need them.
Update also to a compatible Gradle version
Gradle versions higher than 8.14 require JDK 17, thus it makes jitpack to fail as it uses JDK 11 by default
Closed
elihart
approved these changes
Jan 7, 2026
Contributor
elihart
left a comment
elihart
left a comment
There was a problem hiding this comment.
I think this looks pretty good overall, thanks!
Since this PR is newer and seems complete I think we should take it over the earlier PR
| }?.annotationValues | ||
| ?.any { annotationValue -> | ||
| annotationValue.value.toString() == deepLinkParamType.toString() | ||
| annotationValue.value.toString() == deepLinkParamType.toAnnotationValue() |
Contributor
There was a problem hiding this comment.
I'm wondering if we can do this comparison in a safer way. I can try to explore it
| kotlinCompileTestingVersion : '0.6.0', | ||
| kspVersion : '2.0.21-1.0.28', | ||
| xProcessorVersion : '2.6.0-alpha01', | ||
| kotlinCompileTestingVersion : '0.11.0', |
Contributor
There was a problem hiding this comment.
there is a newer release https://github.com/ZacSweers/kotlin-compile-testing/releases/tag/0.12.1
Suggested change
| kotlinCompileTestingVersion : '0.11.0', | |
| kotlinCompileTestingVersion : '0.12.1', |
| kspVersion : '2.0.21-1.0.28', | ||
| xProcessorVersion : '2.6.0-alpha01', | ||
| kotlinCompileTestingVersion : '0.11.0', | ||
| kspVersion : '2.3.3', |
Contributor
There was a problem hiding this comment.
Suggested change
| kspVersion : '2.3.3', | |
| kspVersion : '2.3.4', |
| @@ -0,0 +1,2 @@ | |||
| jdk: | |||
Contributor
There was a problem hiding this comment.
Can you explain this? I don't believe we use jitpack at all
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I've took some time to try to migrate the library to KSP2 with the help of Claude Code, as I didn't had much experience with KSP before.
My process was:
DeepLinkProcessor.DeepLinkProcessorto make the test pass.Everything looks good so far, but let me know is something should be changed.
This PR should fix #369
I saw there's another PR (#371) trying to update to KSP2, I'm not sure which one is better, but this one is up to date with the main branch and everything looks ready.
cc @rossbacher