Migrate to KSP2#378
Migrate to KSP2#378eduardbosch wants to merge 13 commits intoairbnb:rossbacher-manifestGenerationfrom
Conversation
eduardbosch
force-pushed
the
feature/migrate-to-ksp2
branch
2 times, most recently
from
2c56f1c to
8ebec09
Compare
|
@eduardbosch thank you! We will need to merge #377 before that as we need that without ksp2 so that most likely will need to be rebased once that one gets reviewed and merged. Just fyi. |
eduardbosch
force-pushed
the
feature/migrate-to-ksp2
branch
from
2276eb6 to
89b4565
Compare
eduardbosch
changed the base branch from
master
to
rossbacher-manifestGeneration
No problem, I've rebased the banch and fixed the conflicts. It should be ready now. Let me know if I can help with anything. |
|
As long as |
- Add namespace. - Configure java version. - Update Gradle.
Use the configureKsp function to initialize KSP.
KAPT does not add the parent class while KSP does
KSP shows values in different order than KAPT and it makes some tests to fail. Ensure we have the same output for all processors.
Type elements can become invalid after PSI changes so it's safer to query them when we need them.
eduardbosch
force-pushed
the
feature/migrate-to-ksp2
branch
from
89b4565 to
bc9bc39
Compare
|
Great, so then it should be good. |
Update also to a compatible Gradle version
Gradle versions higher than 8.14 require JDK 17, thus it makes jitpack to fail as it uses JDK 11 by default
eduardbosch
force-pushed
the
feature/migrate-to-ksp2
branch
from
6063683 to
e58d42a
Compare
| jdk: | ||
| - openjdk17 |
There was a problem hiding this comment.
I needed to configure this in order to test the changes on my app. I'm not sure if that's something we want to keep or revert before merging this PR
|
@eduardbosch This was closed by gibhub as it was based on my manifest generation branch, which is now merged. Rebase this on master and get all the tests running and we can review and merge that as a new release with ksp2 support. Will probably be in the new year though. |
|
No problem @rossbacher Merry Christmas and Happy New Year 🎄 |
2 participants
Hi 👋
I've took some time to try to migrate the library to KSP2 with the help of Claude Code, as I didn't had much experience with KSP before.
My process was:
DeepLinkProcessor.DeepLinkProcessorto make the test pass.Everything looks good so far, but let me know is something should be changed.
This PR should fix #369
I saw there's another PR (#371) trying to update to KSP2, I'm not sure which one is better, but this one is up to date with the main branch and everything looks ready.
cc @rossbacher