[AAASM-3942] ✨ (skills): Add reusable org-level skill files#28
Conversation
|
Claude Code review — AAASM-3942 CI: Red, same org-wide Actions billing-block (see #25) — not caused by this change. Scope vs ticket: Matches AAASM-3942's AC — all 7 skill files present ( Side effects: None. Frontend: N/A. Recommend: ready to merge, after #26 (independent of #27, can merge before or after it). |
Chisanan232
force-pushed
the
v0.1.0/AAASM-3942/design_claude_skills
branch
from
7f2feb5 to
3e9367a
Compare
…list Adds an explicit "all CI checks are green" checklist item to pr-review.md, naming the one accepted exception (the org's known GitHub Actions billing-block, which completes instantly with zero jobs) so it isn't confused with a real failure. Also tightens the existing secrets checklist item to reference .claude/rules/01-security.md instead of only calling out .env files.
…ntation No skill previously referenced the security rule outside pr-review.md's narrow secrets check. Adds a pointer to .claude/rules/01-security.md in the Implement step, since that's where a security-relevant decision actually gets made — not just at final review time.
Adds .claude/rules/01-security.md to onboard-org's step 1 reading list, alongside CLAUDE.md/AGENTS.md, so a new contributor sees it before writing any code rather than only at PR-review time.
|
Claude Code: 3 follow-up commits added per review feedback
Answering the second review question directly: before this, only `pr-review.md` mentioned security at all, and only narrowly (secrets/`.env`) — the other 6 skills never referenced `01-security.md`. Now `onboard-org`, `contribution-guide`, and `pr-review` all point to it; `choose-repo`, `task-intake`, `setup-dev-env`, and `issue-classification` still don't (and don't obviously need to — none of them touch code or secrets directly). |
Distinct from pr-review.md (author's self-check before requesting review): this is the reviewer-side skill for checking a PR that already exists — CI status (with the billing-block carve-out), ticket-scope cross-check, side-effect/correctness verification via the real diff (not the author's self-report), a security pass against 01-security.md, and Playwright validation when the PR touches frontend code. Ends in a PR comment as the review record, with a default of reporting findings rather than approving/merging.
|
Added new skill: `pr-reviewer.md` Codifies the reviewer-side flow (distinct from author-side `pr-review.md`) actually used when reviewing AAASM-3939 through 3947's PRs: CI status with the billing-block carve-out, ticket-scope cross-check against Jira description/AC/comments, side-effect/correctness check via the real diff (not the author's self-report), a security pass against `01-security.md`, and Playwright validation + screenshot/recording capture when FE code is touched. Ends in a PR comment as the record, defaults to reporting findings rather than approving/merging on its own authority. This PR's skill count: 8 (7 original + this one). |
1 participant
Jira Ticket
Summary
.claude/skills/with 7 focused, task-specific playbooks for common org workflows (onboarding, repo selection, ticket intake, dev-env setup, contribution flow, PR self-review, issue triage). Each skill links back toCLAUDE.md/AGENTS.md/.claude/WORKSPACE.mdfor policy instead of restating it, per the ticket's design goal. Depends on [AAASM-3939] 📝 (workspace): Add org-level AI workspace layout doc #25 and [AAASM-3940] ✨ (docs): Add org-level CLAUDE.md and AGENTS.md baseline #26 (stacked, not yet merged).Changes
.claude/skills/onboard-org.md— first steps for a brand-new contributor (human or AI): read org baseline, pick a repo, bootstrap workspace, read repo-local CLAUDE.md.claude/skills/choose-repo.md— decision tree for picking the right org repo for a given task.claude/skills/task-intake.md— ticket → branch workflow: read ticket/Epic, check dependencies, transition to In Progress, determine branch/stacking.claude/skills/setup-dev-env.md— local machine setup checklist: clone, verify remote naming, per-repo toolchain, pre-commit hooks.claude/skills/contribution-guide.md— end-to-end worktree → implement → commit → push → PR flow.claude/skills/pr-review.md— pre-review self-check checklist.claude/skills/issue-classification.md— triage guide: bug vs feature vs docs vs environment blocker, repo/component, Epic vs standaloneValidation
Checklist
[<ticket ID>] <GitEmoji> (<change scope category>): <key point as summary>