Skip to content

feat: update bridge test #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesusholoo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: update bridge test #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
494105d
feat: update bridge test
jesusholoo Jun 4, 2025
74d83f8
chore: typo
hadjiszs Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
target
tests/kurtosis
tests/tmp
*.env
Copy link
Copy Markdown
Contributor

@iljakuklic iljakuklic Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: line end missing.

20 changes: 3 additions & 17 deletions crates/aggchain-proof-core/src/bridge/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ mod tests {

#[tokio::test(flavor = "multi_thread")]
#[ignore = "e2e test, sepolia provider needed"]
async fn test_bridge_contraints() -> Result<(), Box<dyn std::error::Error>> {
async fn test_bridge_constraints() -> Result<(), Box<dyn std::error::Error>> {
// Initialize the environment variables.
dotenvy::dotenv().ok();

Expand Down Expand Up @@ -660,7 +660,7 @@ mod tests {
let evm_sketch = |block_number: u64| {
EvmSketch::builder()
.at_block(BlockNumberOrTag::Number(block_number))
.with_genesis(Genesis::Sepolia)
.with_genesis(Genesis::Mainnet)
.el_rpc_url(rpc_url_l2.clone())
};

Expand All @@ -670,20 +670,6 @@ mod tests {
(prev, new)
};

// 1. Get the prev inserted GER hash chain (previous block on L2)
Copy link
Copy Markdown
Contributor

@iljakuklic iljakuklic Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Since the point number one was removed, the subsequent comments should be renumbered (or just have the numbering removed).

println!("Step 1: Fetching previous inserted GER hash chain...");
let hash_chain = prev_l2_block_executor
.call(
ger_address,
Address::default(),
GlobalExitRootManagerL2SovereignChain::insertedGERHashChainCall {},
)
.await?;
println!(
"Step 1: Received prev inserted GER hash chain: {:?}",
hash_chain
);

// 2. Get the new inserted GER hash chain (new block on L2)
println!("Step 2: Fetching new inserted GER hash chain...");
let new_hash_chain = new_l2_block_executor
Expand Down Expand Up @@ -939,7 +925,7 @@ mod tests {
// In that case, you should update the file.
// The process is to:
// 1. Obtain a Sepolia RPC key, and run `export RPC_11155111=https://eth-sepolia.g.alchemy.com/v2/[censored]`
// 2. Run `cargo test --workspace -- bridge::tests::test_bridge_contraints
// 2. Run `cargo test --workspace -- bridge::tests::test_bridge_constraints
// --exact --show-output --include-ignored` (Or you can limit to `--package
// aggchain-proof-core --lib` if your cargo folder is not filled yet)
// 3. The file should then be ready for committing
Expand Down
Loading