Skip to content

Conversation

@invocamanman
Copy link
Contributor

Description

Updated the bridge test with the new smart contracts:
Also make the test with genesis Mainnet

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@invocamanman invocamanman requested a review from hadjiszs June 4, 2025 14:34
@invocamanman invocamanman requested a review from a team as a code owner June 4, 2025 14:34
@invocamanman invocamanman requested review from iljakuklic and removed request for a team June 4, 2025 14:34
@hadjiszs hadjiszs force-pushed the feat/update-bridge-test branch from 78be5ec to 74d83f8 Compare June 9, 2025 06:35
@hadjiszs hadjiszs changed the base branch from feat/upgrade-sp1-5 to main June 9, 2025 06:35
Copy link
Contributor

@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Have not thoroughly go through the massive json file though 😅

(prev, new)
};

// 1. Get the prev inserted GER hash chain (previous block on L2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Since the point number one was removed, the subsequent comments should be renumbered (or just have the numbering removed).

target
tests/kurtosis
tests/tmp
*.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: line end missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants