Skip to content

Add agent-knowledge as git submodule #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avifenesh merged 1 commit into from
Mar 5, 2026
Merged

Add agent-knowledge as git submodule #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .claude/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"version": "1.0.0",
"tasks": [
{
"id": "2",
"source": "agent-sh/agent-sh.dev",
"title": "Org Architecture: Documentation & Website Strategy",
"branch": "feature/org-docs-strategy-2",
"worktreePath": "/home/ubuntu/agent-sh/worktrees/org-docs-strategy-2",
Copy link

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The worktreePath is using a hardcoded absolute path (/home/ubuntu/...). This is not portable and will cause issues for other developers on different machines. This path should be relative, configurable via an environment variable, or if it's a user-specific setting, this file should be added to .gitignore.

"claimedAt": "2026-02-22T00:00:00Z",
"claimedBy": "worktree-manager",
"status": "claimed",
Comment on lines +9 to +12
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop committing machine-local task claim state

This file stores mutable, workstation-specific scheduler state (worktreePath, status: "claimed", and timestamps), so committing it will immediately make the repo contain stale claim data for every other checkout and create unnecessary churn/conflicts as different environments update task metadata. In practice, collaborators and automation inherit a hard-coded /home/ubuntu/... path and pre-claimed task state that is not valid outside the original machine, so this should be kept out of version control.

Useful? React with 👍 / 👎.

"lastActivityAt": "2026-02-22T00:00:00Z"
Comment on lines +10 to +13
Copy link

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The claimedAt and lastActivityAt timestamps are set to a date far in the future (2026). While this might be a placeholder, it can be confusing and may cause issues with any logic that processes these tasks based on their timestamps. Consider using a null value or a more standard placeholder format if that's the intention.

}
]
}
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "agent-knowledge"]
path = agent-knowledge
url = https://github.com/agent-sh/agent-knowledge.git
1 change: 1 addition & 0 deletions agent-knowledge
Open in desktop
Submodule agent-knowledge added at ec4179