Skip to content

Add agent-knowledge as git submodule#6

Merged
avifenesh merged 1 commit intomainfrom
feat/agent-knowledge-submodule
Mar 5, 2026
Merged

Add agent-knowledge as git submodule#6
avifenesh merged 1 commit intomainfrom
feat/agent-knowledge-submodule

Conversation

@avifenesh
Copy link
Contributor

Summary

  • Adds agent-knowledge as a git submodule pointing to agent-sh/agent-knowledge
  • Centralizes the shared knowledge base across all plugin repos
  • Single source of truth - update once, pull everywhere

Test plan

  • Verify git submodule update --init works after clone
  • Confirm knowledge files are accessible at agent-knowledge/

Centralizes knowledge base in agent-sh/agent-knowledge repo,
shared across all plugin repos via submodule.
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the agent-knowledge repository as a Git submodule. This change aims to centralize and standardize the shared knowledge base across various plugin repositories, ensuring that all projects reference a consistent and up-to-date set of knowledge files from a single source.

Highlights

  • Git Submodule Addition: Added agent-knowledge as a Git submodule, linking to agent-sh/agent-knowledge.
  • Knowledge Base Centralization: Centralized the shared knowledge base across all plugin repositories.
  • Single Source of Truth: Established a single source of truth for knowledge, allowing updates in one place to propagate everywhere.
Changelog
  • .claude/tasks.json
    • Added a new JSON configuration file for task management, potentially related to development environment setup.
  • .gitmodules
    • Introduced the configuration for the agent-knowledge Git submodule, specifying its path and URL.
  • agent-knowledge
    • Added the agent-knowledge directory as a Git submodule, pointing to a specific commit hash.
Activity
  • No human activity has been recorded on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the agent-knowledge repository as a git submodule, which is a good step towards centralizing shared knowledge. My review includes a couple of points on the newly added .claude/tasks.json file regarding a hardcoded absolute path and a potentially confusing future date value. The submodule addition itself looks correct.

"source": "agent-sh/agent-sh.dev",
"title": "Org Architecture: Documentation & Website Strategy",
"branch": "feature/org-docs-strategy-2",
"worktreePath": "/home/ubuntu/agent-sh/worktrees/org-docs-strategy-2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The worktreePath is using a hardcoded absolute path (/home/ubuntu/...). This is not portable and will cause issues for other developers on different machines. This path should be relative, configurable via an environment variable, or if it's a user-specific setting, this file should be added to .gitignore.

Comment on lines +10 to +13
"claimedAt": "2026-02-22T00:00:00Z",
"claimedBy": "worktree-manager",
"status": "claimed",
"lastActivityAt": "2026-02-22T00:00:00Z"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The claimedAt and lastActivityAt timestamps are set to a date far in the future (2026). While this might be a placeholder, it can be confusing and may cause issues with any logic that processes these tasks based on their timestamps. Consider using a null value or a more standard placeholder format if that's the intention.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b46ee838e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +9 to +12
"worktreePath": "/home/ubuntu/agent-sh/worktrees/org-docs-strategy-2",
"claimedAt": "2026-02-22T00:00:00Z",
"claimedBy": "worktree-manager",
"status": "claimed",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop committing machine-local task claim state

This file stores mutable, workstation-specific scheduler state (worktreePath, status: "claimed", and timestamps), so committing it will immediately make the repo contain stale claim data for every other checkout and create unnecessary churn/conflicts as different environments update task metadata. In practice, collaborators and automation inherit a hard-coded /home/ubuntu/... path and pre-claimed task state that is not valid outside the original machine, so this should be kept out of version control.

Useful? React with 👍 / 👎.

@avifenesh avifenesh merged commit 3579a15 into main Mar 5, 2026
@avifenesh avifenesh deleted the feat/agent-knowledge-submodule branch March 5, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant