Conversation
Centralizes knowledge base in agent-sh/agent-knowledge repo, shared across all plugin repos via submodule.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the agent-knowledge repository as a git submodule, which is a good step towards centralizing shared knowledge. My review includes a couple of points on the newly added .claude/tasks.json file regarding a hardcoded absolute path and a potentially confusing future date value. The submodule addition itself looks correct.
| "source": "agent-sh/agent-sh.dev", | ||
| "title": "Org Architecture: Documentation & Website Strategy", | ||
| "branch": "feature/org-docs-strategy-2", | ||
| "worktreePath": "/home/ubuntu/agent-sh/worktrees/org-docs-strategy-2", |
There was a problem hiding this comment.
The worktreePath is using a hardcoded absolute path (/home/ubuntu/...). This is not portable and will cause issues for other developers on different machines. This path should be relative, configurable via an environment variable, or if it's a user-specific setting, this file should be added to .gitignore.
| "claimedAt": "2026-02-22T00:00:00Z", | ||
| "claimedBy": "worktree-manager", | ||
| "status": "claimed", | ||
| "lastActivityAt": "2026-02-22T00:00:00Z" |
There was a problem hiding this comment.
The claimedAt and lastActivityAt timestamps are set to a date far in the future (2026). While this might be a placeholder, it can be confusing and may cause issues with any logic that processes these tasks based on their timestamps. Consider using a null value or a more standard placeholder format if that's the intention.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b46ee838e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "worktreePath": "/home/ubuntu/agent-sh/worktrees/org-docs-strategy-2", | ||
| "claimedAt": "2026-02-22T00:00:00Z", | ||
| "claimedBy": "worktree-manager", | ||
| "status": "claimed", |
There was a problem hiding this comment.
Stop committing machine-local task claim state
This file stores mutable, workstation-specific scheduler state (worktreePath, status: "claimed", and timestamps), so committing it will immediately make the repo contain stale claim data for every other checkout and create unnecessary churn/conflicts as different environments update task metadata. In practice, collaborators and automation inherit a hard-coded /home/ubuntu/... path and pre-claimed task state that is not valid outside the original machine, so this should be kept out of version control.
Useful? React with 👍 / 👎.
Summary
agent-knowledgeas a git submodule pointing toagent-sh/agent-knowledgeTest plan
git submodule update --initworks after cloneagent-knowledge/