remove extra space if there are not children

[vraja-pro]

Context

Summary

This PR can be summarized in the following changelog entry:

• Remved extra space in task modal.

Relevant technical choices:

• The gradient element used for the bottom of the scroll takes space, it will now render only when there is children to the modal, I moved the bottom padding to to the content, in that way the gradient element will also take the place of the padding bottom.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Go to Yoast SEO -> Task list
• Open a task without child tasks and check there is 24px space between the about content and the footer.
• Open a task with children
• Check there is a scroll and agradient overlay at the bottom.
  *Scroll to the end untell the gradient disappears.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
• This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.
• I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes Task lise: Remove extra space in task modal

[coveralls]

Pull Request Test Coverage Report for Build 33564e46ea61f5181b29b66df0efc0f6e43b0d70

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 56.496%

---

Totals
Change from base Build 8c08e42cc37b02d75d66d8edd429eb7c0454f677:	0.0%
Covered Lines:	15128
Relevant Lines:	26116

---

💛 - Coveralls

[thijsoo]

CR + ACC 👍