Draft
Conversation
For future reusability in shopify
…logic-to-the-dashborad-frontend-task-list-store Move task list logic to the store
…group along with its grouped tasks that for now are about recent posts with no keyword
…o-retrieve-subtasks-for-the-improve-your-contents-seo-task
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t-and-delete-hello-world-tasks-dont-receive-completed-icon-immediately-after-the-tasks-are-completed Task list: Also update the status of the currently open task when it's completed
…1068-fix-task-list-ux-feedback
…e-displayed-with-encoded-html-entities Decode HTML entities for child task titles
We are ok with NA but not if total is 0
Finalize copies for the task list.
1068 fix task list ux feedback
…hild-tasks-open-in-a-new-tab Open the CTA in a new tab if parentTaskID is available
…-fade-to-parent-tasks 1076 task list add scrollbar and fade to parent tasks
…as bad, to have same behavior with the dashboard widget
…ge-case-when-readability-score-is-0-the-task-list-breaks Fix edge case where readability being 0 breaks the task list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is a draft PR that has been created already in case it helps us add test instructions in one place.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test the backend logic for the SEO task (from #22891)
Improve the SEO of your recent content: Poststask and that it's open/incomplete and that it has a1/3progress badgeOpen editorone) redirects you to the post editor for that post, in a new tab.Test the backend logic for the Readability task (from #22947)
Improve the readability of your recent content: Poststask that:Improve the readability of your recent content: Postsyou will seeImprove the readability of your recent content: PageCalculate duration of the SEO parent task (from #22950)
Improve the SEO of your recent content: Poststask and the parentImprove the SEO of your recent content: Pagestask is 0 (because all child tasks are completed)Improve the SEO of your recent content: Postsis 10 minutes (which is the sum of the incomplete child tasks) and the parentImprove the SEO of your recent content: Pagestask is 10 (which is the sum of the incomplete child tasks)Improve the SEO of your recent content: Postsis now 20 minutes (which is the sum of the incomplete child tasks again)Child task section and updated task row design (from #22934)
Progresswas added to the table.Apply feedback from UX team (from #22990)
Modals
Check modal max width is 672px width and Tailwind class w-2xl.
Check gap between button in the modal footer is 12px.
Check the metadata in the tasks:
Check the mobile design for the task list and the child task list.
Check the progress badge in the modal for child task is above the task title.
Check the the badge label is truncated when it overflows.
Disable development mode or indexables andcheck parent tasks has "No tasks detected" message.
Check loading task list on mobile is also adjusted.
Improve UX in parent tasks with lots of child tasks in small screens (from #23008)
Improve progress badge (from #23008)
Tests for copies (from #22993 and from https://github.com/Yoast/wordpress-seo-premium/pull/4892)
Tests about the
analyzerattribute (backend logic from #22959 and frontend from #22963)Prerequisites
For SEO child tasks:
Good→ "Your content is well optimized for search engines. This increases your chances of ranking higher in search results."OK→ "Your content is partially optimized. Adding a few more SEO best practices will help you reach a wider audience."Needs Improvement→ "Your content is not yet optimized for search. Follow the SEO recommendations to help search engines understand and rank your page."For readability child tasks:
Good→ "Your content is clear and easy to read. This helps your audience stay engaged with your message."OK→ "Your content is readable but could be clearer. Consider simplifying a few sentences to improve the overall flow."Needs Improvement→ "Your content is currently difficult to read. Check the analysis for specific ways to simplify your writing for a better user experience."Prevent showing tasks about content SEO if not applicable (from #22940)
Improve the SEO of your recent content: Poststask and its childrenwp transient delete --alladd_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );filter and repeat the GET requestImprove the SEO of your recent content: Poststask and its childrenwp transient delete --alladd_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );filterImprove the SEO of your recent content: Poststask and its childrenwp transient delete --alladd_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );filterimprove-content-seo-posttask and its children (search for improve-content-seo- in the response and you will get no resultsPrevent showing tasks about content Readability if not applicable (from #22947)
Improve the readability of your recent content: Poststask and its childrenwp transient delete --alladd_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );filter and repeat the GET requestImprove the readability of your recent content: Poststask and its childrenwp transient delete --alladd_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );filterImprove the readability of your recent content: Poststask and its childrenwp transient delete --allImprove the readability of your recent content: Poststask and its childrenTask list and Dashboard use the same source of posts
The task list's "Recent content" tasks and the dashboard's score widgets must query the same population of posts (at least if we assume that all posts have been modified the last 2 months). The following shared conditions must hold in both places. For each condition, verify that both the dashboard widget and the task list entries behave identically.
1. Only published posts are included
Improve the SEO of your content type: Poststask , will not display a child task for that post.2. Only posts of the selected content type are included
Both queries filter on
object_sub_type = <content type>.3. Noindex posts are excluded from SEO scores
Both the dashboard SEO widget and the task list SEO widget require
is_robots_noindex IS NULL OR is_robots_noindex <> 1.Show posts in search resultssetting). Verify the post appears in both places.4. Only posts saved from the editor with Yoast active are included in readability scores
Both queries use
estimated_reading_time_minutesto determine whether a post has been analyzed. This field is only populated when a post is saved from the block/classic editor while Yoast is active.5. Posts without a focus keyphrase are excluded from SEO scores
The task list SEO query requires
primary_focus_keyword_score IS NOT NULL AND primary_focus_keyword_score <> 0. The dashboard SEO widget buckets these as "not analyzed."Fixes of unreleased bugs for completing tasks (from #22967)
Fixes of bug of HTML entities in the frontend (from #23001)
Title's bugImprove the readability of your content type: PoststaskTitle's bugand not asTitle’s bugImprove the SEO of your content type: PoststaskTitle's bugand not asTitle’s bugOpen the CTA in a new tab (from #23005)
Improve the readability of your recent contenttask: your post/page with a bad readability score should be visible as its child taskOpen editorbuttonImprove the SEO of your recent contenttask: your post/page with a bad SEO score should be visible as its child taskOpen editorbuttonEnable llms.txtandDelete Hello Worldtasks, which are special because their CTAs don't redirect you to any page, but rather perform an action under the hood), click on its CTA and confirm that you get a redirected in a new tab in the page that you are supposed toEnable llms.txtandDelete Hello Worldtasks, click on their CTAs and confirm that:Loading state should show 10 rows (from #22767)
Sorting tasks in the list (from #22781)
Error fetching tasks: Added invalid task.Add user locale support for task list duration (from #22927)
Check Free and Premium mismatch in versions
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Top 5 most popular contentwidget in the Site Kit integrationYoast SEO scoreof each URL in that widget is the same color with this PR and withoutOther environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand commited the results, if my PR introduces new images or SVGs.Innovation
innovationlabel.Fixes #