Better lift variable names#54
Open
andrewmcalinden wants to merge 62 commits intoliftVariableNamesfrom
Open
Conversation
This reverts commit 027ecb2.
… speed adjustments. removed driver pipeline button
removed space
Override the frc::XboxController with a new ValorGamepad class This will inherit all the same methods as XboxController, but also provide additional methods for utilizing a deadband on the X and Y sticks, as well as a deadband on the triggers. Prevent caching all the values in each subsystem's state struct
Allow sensors to be their own object, which simplifies the logic in the subsystems. This also allows us to re-use common sensor types year over year. For example the current sensing circular buffer on our intake is a good sensor to use in the future, therefore create a ValorCurrentSensor that can be used by multiple subsystems
If someone forgets to set the getter function for a ValorSensor (which inevitably will happen), then return 0. If the getter function is indeed set, then use it when getting the sensor
While holding left trigger, shoot the ball towards our hanger zone
…mit and changed to half of forward rotate limit for intake
… working, changed max speed values to usable values
…es and forward limit to 27, added voltage compensation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.