Open
Conversation
Collaborator
|
The following changes are needed:
|
Author
|
Requested changes made |
bgoldbug
reviewed
Feb 12, 2026
Collaborator
bgoldbug
left a comment
There was a problem hiding this comment.
Requested changes to config.mk and verilog.mk
Collaborator
There was a problem hiding this comment.
All DESIGN_HOME vars need to be replaced with BENCH_DESIGN_HOME
Collaborator
There was a problem hiding this comment.
By default, we want the cnn.v file to exist outside of the dev directory, such that it's available for users without needing to run make dev initially.
- When I try to run
makeas the first command, it says:cnn.v is missing; using dev RTL. Run 'make dev' to regenerate and promote. - It should instead use an existing cnn.v (existing without running
make dev)
Author
|
This should fix those problems |
increased design area increased clock speed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.