Skip to content

Conversation

@transcommwende
Copy link

#29

@DohmenClaus DohmenClaus added this to the Version 2.0.0 milestone Jul 17, 2025
@DohmenClaus DohmenClaus self-assigned this Jul 17, 2025
@DohmenClaus
Copy link
Contributor

Torsten Karstädt bearbeitet

Copy link
Collaborator

@tkarstaedt tkarstaedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 typos "Predicition" (should be Prediction)

ChargingProgressPredicitionList --> typo --> ChargingProgressPredictionList

#/definitions/ChargingProgressPredicitionListEntry --> typo --> #/definitions/ChargingProgressPredictionListEntry

ChargingProgressPredicitionListEntry --> typo --> ChargingProgressPredictionListEntry

@tkarstaedt
Copy link
Collaborator

Ich schlage folgende Änderungen vor:

  • Typos beseitigen (Predicition)
  • Description für ChargingProgressPredictionListEntry hinzufügen
  • Description für predictedSoc
  • minimum/maximum für predictedSoc
  • Description für predictedTime
  • additionalProperties verneinen auf Objektebene (ChargingProgressPredictionListEntry)
        "ChargingProgressPredictionList": {
            "description": "This type represents a time series for predicting the charging process (internal extrapolation).",
            "type": "array",
            "items": {
                "$ref": "#/definitions/ChargingProgressPredictionListEntry"
            },
            "additionalProperties": false
        },
        "ChargingProgressPredictionListEntry": {
            "description": "This type represents a single prediction data point for the charging process forecast.",
            "type": "object",
            "properties": {
                "predictedSoc": {
                    "type": "number",
                    "minimum": 0,
                    "maximum": 100,
                    "additionalProperties": false,
                    "description": "Predicted state of charge in percent (0-100)."
                },
                "predictedTime": {
                    "type": "string",
                    "format": "date-time",
                    "additionalProperties": false,
                    "description": "Timestamp when the predicted SoC is expected to be reached."
                }
            },
            "required": [
                "predictedSoc",
                "predictedTime"
            ],
            "additionalProperties": false
        },

tkarstaedt pushed a commit to tkarstaedt/VDV463 that referenced this pull request Nov 10, 2025
…DVde#29, supersedes VDVde#55)

- Fix typo: 'Predicition' -> 'Prediction' in names and references
- Add missing description for ChargingProgressPredictionListEntry
- Add descriptions for predictedSoc and predictedTime properties
- Add min/max constraints for predictedSoc (0-100)
- Add additionalProperties: false at object level
- Improve descriptions for better clarity
@DohmenClaus DohmenClaus added the specification Improvements or additions to specification label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

specification Improvements or additions to specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants