Fix typos and improve ChargingProgressPrediction definitions (fixes #… #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2025 00:16
…DVde#29, supersedes VDVde#55) - Fix typo: 'Predicition' -> 'Prediction' in names and references - Add missing description for ChargingProgressPredictionListEntry - Add descriptions for predictedSoc and predictedTime properties - Add min/max constraints for predictedSoc (0-100) - Add additionalProperties: false at object level - Improve descriptions for better clarity
BenjaminKowatschVector
added
the
specification
BenjaminKowatschVector
requested changes
Jan 27, 2026
Collaborator
BenjaminKowatschVector
left a comment
BenjaminKowatschVector
left a comment
There was a problem hiding this comment.
Hallo Torsten,
wie besprochen sollten wir noch die Anzahl an Elementen begrenzen.
Ich habe bereits ein Änderungsvorschlag dafür erstellt.
| "items": { | ||
| "$ref": "#/definitions/ChargingProgressPredictionListEntry" | ||
| }, | ||
| "additionalProperties": false |
Collaborator
There was a problem hiding this comment.
Suggested change
| "additionalProperties": false | |
| "minItems": 0, | |
| "maxItems": 10, | |
| "additionalProperties": false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: ChargingProgressPrediction Typos and Improvements
Fixes #29 (supersedes #55)
Changes
ChargingProgressPredicition→ChargingProgressPredictionChargingProgressPredicitionListEntry→ChargingProgressPredictionListEntryChargingProgressPredictionListEntryobjectpredictedSocandpredictedTimepropertiespredictedSoc(0-100)additionalProperties: falseat object level for better schema validationRelated
Validation