Skip to content

fix(apollo-react): stabilize panOnDrag array reference to prevent unnecessary re-renders #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snuziale merged 1 commit into from
Feb 27, 2026
Merged

fix(apollo-react): stabilize panOnDrag array reference to prevent unnecessary re-renders #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/apollo-react/src/canvas/components/BaseCanvas/BaseCanvas.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ export const BASE_CANVAS_DEFAULTS = {
organizeAnimationDuration: 500,
} as const;

/** Stable reference: restrict panning to middle-mouse-button only so left-click stays free for node interaction */
export const PAN_ON_DRAG: [number] = [1];

// Timing constants
export const FIT_VIEW_DELAY_MS = 50;
export const CANVAS_READY_DELAY_MS = 50;
Expand Down
4 changes: 2 additions & 2 deletions packages/apollo-react/src/canvas/components/BaseCanvas/BaseCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
useState,
} from 'react';
import { useToolbarActionStore } from '../../hooks/ToolbarActionContext';
import { BASE_CANVAS_DEFAULTS } from './BaseCanvas.constants';
import { BASE_CANVAS_DEFAULTS, PAN_ON_DRAG } from './BaseCanvas.constants';
import { useAutoLayout, useEnsureNodesInView, useMaintainNodesInView } from './BaseCanvas.hooks';
import type { BaseCanvasProps, BaseCanvasRef } from './BaseCanvas.types';
import { CanvasBackground } from './CanvasBackground';
Expand Down Expand Up @@ -175,7 +175,7 @@ const BaseCanvasInnerComponent = <NodeType extends Node = Node, EdgeType extends
panOnScroll={isInteractive}
zoomOnScroll={isInteractive}
zoomOnDoubleClick={isInteractive && zoomOnDoubleClick}
panOnDrag={isInteractive ? [1] : false}
panOnDrag={isInteractive ? PAN_ON_DRAG : false}
onInit={handleInit}
onNodesChange={isInteractive ? onNodesChange : undefined}
onEdgesChange={isInteractive ? onEdgesChange : undefined}
Expand Down
Loading