Conversation
…ecessary re-renders
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR addresses a performance issue in the BaseCanvas component by extracting an inline array literal [1] to a stable constant PAN_ON_DRAG. This prevents creating a new array reference on every render, which could trigger unnecessary re-renders in the ReactFlow component due to reference inequality checks.
Changes:
- Extract inline
[1]array toPAN_ON_DRAGconstant to stabilize reference across renders
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/components/BaseCanvas/BaseCanvas.tsx | Updated panOnDrag prop to use the new PAN_ON_DRAG constant instead of inline [1] array |
| packages/apollo-react/src/canvas/components/BaseCanvas/BaseCanvas.constants.ts | Added PAN_ON_DRAG constant with proper tuple type annotation and explanatory comment |
CalinaCristian
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary