Fix vf counts#3
Draft
JefferyLim wants to merge 1 commit into
Draft
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of my MS Thesis at Boston University, I used OS4C as the baseline NIC design for my work.
Unfortunately, it appeared as though there were a few things that did not work in this design, and so I spent a few months fixing the repository to a working state.
That being said, there are likely bugs that I have not found yet, so hopefully this is a strong baseline that people can work off from.
This PR adds a VF_COUNT parameter in
config.tclwhich allows you to determine how many VFs you would like to create. All the FUNCTION_ID_WIDTH related math should be replaced with a F_COUNT (VF_COUNT + PF_COUNT) version.FUNCTION_ID_WIDTH is now just the width of the function id (8 bits) that the PCIe core provides.
This does not include the
pcie_msix.vfix so there may be certain workloads that crash the system.