Stat recording improvements#3634
Draft
StarrryNight wants to merge 5 commits intoUBC-Thunderbots:masterfrom
Draft
Stat recording improvements#3634StarrryNight wants to merge 5 commits intoUBC-Thunderbots:masterfrom
StarrryNight wants to merge 5 commits intoUBC-Thunderbots:masterfrom
Conversation
… and prohibit robot removal in record stat mode
…o game controller to compensate for the red card
…/Thunderbots into stat_recording_improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #3633.
It is currently partially completed.
--record stats can trigger stat recording without needing other flags
On top of record_stats, record_stats_durationn_s is also introduced so we can specify how long we collect data
red cards disabled in --record_stats
Done by fixing number of robots, and sending UpdateConfig proto to update
max robot on team xon ssl gamecontroller. If UpdateConfig is not sent, play will halt due totoo many robotsautomatically approve goals and restart game after goal
automatically place ball
Testing Done
Before: Number of blue robots reduced
Screencast from 2026-03-01 16-19-59.webm
After: Giving red cards doens't reduce robots
Screencast from 2026-03-01 16-45-44.webm
Resolved Issues
#3633.
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue