Skip to content

Stat recording improvements#3634

Draft
StarrryNight wants to merge 5 commits intoUBC-Thunderbots:masterfrom
StarrryNight:stat_recording_improvements
Draft

Stat recording improvements#3634
StarrryNight wants to merge 5 commits intoUBC-Thunderbots:masterfrom
StarrryNight:stat_recording_improvements

Conversation

@StarrryNight
Copy link
Contributor

@StarrryNight StarrryNight commented Mar 2, 2026

Description

This PR resolves #3633.
It is currently partially completed.

  • --record stats can trigger stat recording without needing other flags
    On top of record_stats, record_stats_durationn_s is also introduced so we can specify how long we collect data

  • red cards disabled in --record_stats
    Done by fixing number of robots, and sending UpdateConfig proto to update max robot on team x on ssl gamecontroller. If UpdateConfig is not sent, play will halt due to too many robots

  • automatically approve goals and restart game after goal

  • automatically place ball

Testing Done

  1. --record_stats. Works basically like with --enable_autoref, --ci_mode, and --record_stats enabled before.
  2. Red cards (and yellow cards too) no longer affect number of robots in the game:

Before: Number of blue robots reduced
Screencast from 2026-03-01 16-19-59.webm

After: Giving red cards doens't reduce robots
Screencast from 2026-03-01 16-45-44.webm

Resolved Issues

#3633.

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve record stat

2 participants