Fix python simulated test no robots loading and ai running#3626
Open
nycrat wants to merge 15 commits intoUBC-Thunderbots:masterfrom
Open
Fix python simulated test no robots loading and ai running#3626nycrat wants to merge 15 commits intoUBC-Thunderbots:masterfrom
nycrat wants to merge 15 commits intoUBC-Thunderbots:masterfrom
Conversation
81167c6 to
793298d
Compare
Contributor
|
Can you link #3621 |
5f64ffe to
57f95b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are two bugs that are causing flaky/inconsistent simulated gameplay tests. Firstly, the issue where the WorldState is not initialized when a test starts, and the other when running thunderscope with the simulated tests the tactics get re-assigned automatically.
The first issue is fixed by running setup() repeatedly until WorldStateReceived proto is received. The second issue is fixed by removing the parameters tab (ProtoConfigurationWidget) which sends a ThunderbotsConfig proto that enables PlaySelectionFSM by default.
Testing Done
Ran simulated tests repeatedly, especially the ball placement and HRVO tests which were particularly flaky, and HRVO passes consistently now. Ball placement still fails sometimes, but reviewing the replays, its because of the tactic reassignment oscillation.
Resolved Issues
resolves #3621, resolves #2858
Length Justification and Key Files to Review
Did a lot of refactors to existing pytests to follow best practice and also use the setup parameter for simulated_test_runner.run_test so that the WorldStateReceived is checked.
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue