Skip to content

Add Pass Feature Collection class#3599

Open
sauravbanna wants to merge 8 commits intomasterfrom
sauravbanna/test_pass_data_collection
Open

Add Pass Feature Collection class#3599
sauravbanna wants to merge 8 commits intomasterfrom
sauravbanna/test_pass_data_collection

Conversation

@sauravbanna
Copy link
Contributor

Description

Added a class which logs Pass Features -> features we'd like to use for training weights for judging passes in the future

I put the new class in the passing directory since it made sense

Testing Done

Compiles + next pr will consume the protos generated

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@sauravbanna sauravbanna marked this pull request as ready for review February 18, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants