Nanopb Compiplation Refactor & Protobuf Cleanup#3525
Merged
Andrewyx merged 7 commits intoUBC-Thunderbots:masterfrom Nov 15, 2025
Merged
Nanopb Compiplation Refactor & Protobuf Cleanup#3525Andrewyx merged 7 commits intoUBC-Thunderbots:masterfrom
Andrewyx merged 7 commits intoUBC-Thunderbots:masterfrom
Conversation
williamckha
reviewed
Nov 11, 2025
Member
williamckha
left a comment
There was a problem hiding this comment.
LGTM very clean! Make sure to update CI so that we don't run ubuntu 22 builds any more
Lmh-java
reviewed
Nov 11, 2025
Contributor
Lmh-java
left a comment
There was a problem hiding this comment.
Legendary work! Left some deep questions.
Lmh-java
previously approved these changes
Nov 13, 2025
Contributor
Lmh-java
left a comment
There was a problem hiding this comment.
LGTM. BTW, Github Action scripts should also be changed to address the CI failure.
Lmh-java
previously approved these changes
Nov 14, 2025
Member
|
The pre-commit.yml workflow also needs to be upgraded to Ubuntu 24 |
Lmh-java
approved these changes
Nov 15, 2025
williamckha
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to address the following 3 issues:
nanopb.bzlsetup_software.shto reduce hermiticity issues blocking Add macOS ARM support for Thunderscope #3496 and removed legacy version supporttoolchains_protocTesting Done
deploy_robot_softwareResolved Issues
Resolves #3484
Length Justification and Key Files to Review
nanopb.bzlI've provided documentation on the compile process of this script and how it actually fits into our deploy pipeline. Hopefully this process makes sense now.Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue