-
-
Notifications
You must be signed in to change notification settings - Fork 649
fix: UI elements not scrolling when editor DOM element is scrollable #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "playground": true, | |||
| "docs": true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs: false
| tags: ["Basic", "Blocks"], | ||
| dependencies: { | ||
| "@blocknote/xl-multi-column": "latest", | ||
| export const examples = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run format document to prevent large diff
Summary
This PR fixes a bug where UI elements do not scroll with the editor, when the editor's DOM element is scrollable.
Rationale
This is a regression introduced in #2143.
Changes
contextElementto virtual element inGenericPopover.Impact
N/A
Testing
N/A
Screenshots/Video
N/A
Checklist
Additional Notes