-
-
Notifications
You must be signed in to change notification settings - Fork 649
fix: shadowdom support and example #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other usage we should be aware of?
I didn't find any other breaking functionality. Checked explicitly for usage of In general, we should be careful with any Unfortunately I don't think it's easy to enforce this with eslint |
|
R.e. e2e failures, wait for #2231 to be merged since that fixes them. Nothing major, the custom block e2e tests just use different URLs which aren't appended with the |
Summary
Support for using BlockNote in shadowdom was broken due to usage of
document.queryselectorRationale
n/a
Changes
.closestImpact
n/a
Testing
manual
Screenshots/Video
n/a
Checklist
Additional Notes
n/a