Skip to content

🎨 Palette: Semantic HTML and Language Switcher Accessibility Improvements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Twinber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Semantic HTML and Language Switcher Accessibility Improvements #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-18 - Semantic Link Wrapping Issue
**Learning:** React Router and TanStack Router Links often fail to maintain semantic HTML and native visual structure when wrapped inappropriately (like standard links inside `div` or generic anchor tags), and inline interactive elements (like language switches) implemented with non-interactive `<span>` tags break accessibility boundaries (missing tab targets and roles for screen readers).
**Action:** When adding links or interactions, always use Radix UI's `<Button asChild>` to wrap semantic `<a>` or `<Link>` elements. This preserves accessibility, Shadcn button styling, and native HTML structure simultaneously. For inline interactions (e.g. language switchers), ALWAYS replace generic tags with semantic `<button>`s containing `focus-visible` styles and clear `aria-label` definitions.
Loading