🎨 Palette: Semantic HTML and Language Switcher Accessibility Improvements#17
🎨 Palette: Semantic HTML and Language Switcher Accessibility Improvements#17
Conversation
- Wrap `Link` and `a` elements with `Button asChild` in `NetworkItem` and `GmapsButton` for semantic HTML. - Change `LanguageSwitcher` to use semantic `<button>` elements with `aria-label`s and `focus-visible` styles instead of `<span>` elements. - Add `rel="noopener noreferrer"` to external Google Maps link. - Fix TanStack Router `to` prop usage in `NetworkItem`. - Fix `Number` to `number` type in `GmapsButton` to fix linting error. Co-authored-by: Twinber <5513621+Twinber@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
<span>elements into fully accessible<button>tags within the Language Switcher. Addedaria-labelandfocus-visiblestates.<Button asChild>functionality to properly wrap semantic<Link>and native<a>tags inNetworkItemandGmapsButtonrespectively, preventing nested invalid HTML while preserving visual Shadcn styling.pnpm buildfailure related to template string paths in<Link>.rel="noopener noreferrer"to external window opening links for safety.Numberobject typingeslinterror.🎯 Why:
Interactive elements like Language Switchers must be semantic tab targets for screen readers to work correctly, and keyboard users need visual
focusindicators. Additionally, standard React/Tanstack links should not be wrapped as raw children inside visual<button>styling tags as it creates invalid, non-semantic HTML trees that break browser accessibility mapping.♿ Accessibility:
focus-visible:outlineutilities.aria-labels specifying intent ("Switch language to English").PR created automatically by Jules for task 13566532703678938573 started by @Twinber