Skip to content

🎨 Palette: [UX improvement] Replace non-interactive spans with semantic buttons in LanguageSwitcher #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Twinber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: [UX improvement] Replace non-interactive spans with semantic buttons in LanguageSwitcher #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-18 - Non-interactive elements used for actions
**Learning:** Found that `<span onClick={...}>` was used for language switching. This breaks keyboard navigation (tabbing, pressing enter/space to trigger) and doesn't communicate correctly to screen readers.
**Action:** Replace `<span>` elements that have `onClick` handlers with semantic `<button>` elements, add `aria-label` for screen readers, and add `focus-visible` styles (`focus-visible:outline focus-visible:outline-2 focus-visible:outline-primary focus-visible:outline-offset-2 rounded-sm`) so keyboard navigation is clear. Ensure separators like `/` have `aria-hidden="true"` so they are ignored by screen readers.
Loading