Conversation
…ic buttons in LanguageSwitcher 💡 What: Changed the non-interactive `<span>` elements with `onClick` handlers to semantic `<button>` elements in the `LanguageSwitcher.tsx` component. Added descriptive `aria-label`s, `focus-visible` styling, and `aria-hidden="true"` to the `/` separator. Also documented the learning in `.Jules/palette.md`. 🎯 Why: Non-interactive elements used for interactive actions break keyboard navigation (tabbing, pressing enter/space to trigger) and don't communicate correctly to screen readers. 📸 Before/After: Visual changes include proper focus outlines for keyboard users. ♿ Accessibility: Improves accessibility for screen readers and keyboard users by using semantic HTML and proper ARIA attributes. Co-authored-by: Twinber <5513621+Twinber@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Replaces non-interactive elements used for language switching with semantic buttons, restoring keyboard navigation and improving screen reader accessibility. Included some minor code cleanups discovered during the process (e.g. fixing React Hook dependencies, using primitive numbers in components, and updating TanStack router
Linkprops).PR created automatically by Jules for task 17298193876476796321 started by @Twinber