Skip to content

🎨 Palette: [Accessibility] Improve keyboard navigation and semantic HTML in Language Switcher & Gmaps Button #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Twinber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: [Accessibility] Improve keyboard navigation and semantic HTML in Language Switcher & Gmaps Button #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-03-14 - Radix UI Button asChild pattern for Links
**Learning:** Found an accessibility anti-pattern where standard `<a>` tags were wrapping native `<button>` tags (or components rendering native buttons) to create link-buttons. This results in invalid HTML (interactive element inside an interactive element) and confuses screen readers.
**Action:** Always use Radix UI's `<Button asChild>` to wrap semantic `<a>` tags when you need a link that looks like a button. This preserves the semantic HTML and native accessibility of the anchor tag while applying the Shadcn UI button styling correctly.
Loading