Conversation
* Replaced `<span>` with semantic `<button>` tags in Language Switcher. * Added `focus-visible` styles for better keyboard navigation. * Added `aria-current` to visually highlight the selected language to screen readers. * Used Radix UI `<Button asChild>` to properly wrap the external anchor tag in `GmapsButton`. * Fix TanStack route param typing error in `NetworkItem.tsx`. * Added journal learning about `asChild` link behavior. Co-authored-by: Twinber <5513621+Twinber@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Upgraded
LanguageSwitcherelements from<span>tags withonClickto accessible<button>components. RestructuredGmapsButtonto accurately merge button styling over a proper<a>link.🎯 Why: Enhances overall keyboard navigation by rendering native focus outlines and removes invalid interactive HTML patterns (buttons inside links/links masquerading as buttons).
📸 Before/After: Visual outline for focused interactive elements ensures robust accessibility for power users and impaired individuals.
♿ Accessibility:
aria-labelto language options.aria-currentto accurately reflect the active locale.<button>tag inside a link.PR created automatically by Jules for task 6310727798776677104 started by @Twinber