Skip to content

🎨 Palette: Semantic Button Accessibility fixes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Twinber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Semantic Button Accessibility fixes #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2025-02-17 - Preserve Semantic Structure with Button asChild
**Learning:** Wrapping `<a>` or TanStack Router `<Link>` directly inside a `<Button>` creates invalid HTML (`<button><a>...</a></button>` or similar) which degrades screen reader experiences.
**Action:** Use Radix UI's `<Button asChild>` to preserve both native semantic routing accessibility and design system button styling.
Loading