Skip to content

🎨 Palette: Semantic Button Accessibility fixes#11

Open
Twinber wants to merge 1 commit intomasterfrom
palette/fix-button-semantics-14524418724898109390
Open

🎨 Palette: Semantic Button Accessibility fixes#11
Twinber wants to merge 1 commit intomasterfrom
palette/fix-button-semantics-14524418724898109390

Conversation

@Twinber
Copy link
Owner

@Twinber Twinber commented Mar 12, 2026

🎨 Palette: Semantic Button Accessibility fixes

💡 What:

  • Refactored LanguageSwitcher to use semantic <button> instead of <span> tags. Added clear focus-visible styling and marked the / separator with aria-hidden="true".
  • Refactored NetworkItem and GmapsButton to use Radix UI's <Button asChild> to wrap their inner links, removing invalid HTML structures (a button nested inside an anchor tag) that confuse screen readers.
  • Fixed a parameter casing lint error in GmapsButton.

🎯 Why:

  • Using semantic tags and correctly formed HTML structures is crucial for screen readers and keyboard accessibility.
  • The asChild prop on Shadcn UI/Radix components is a highly effective way to apply component styles to native routing tags (like TanStack <Link> or <a>) without generating deeply nested or invalid HTML.

♿ Accessibility:

  • Restored keyboard focus traversal for LanguageSwitcher.
  • Improved ARIA structure for buttons acting as links.

PR created automatically by Jules for task 14524418724898109390 started by @Twinber

💡 What:
- Refactored `LanguageSwitcher` to use semantic `<button>` instead of `<span>` tags. Added clear `focus-visible` styling and marked the `/` separator with `aria-hidden="true"`.
- Refactored `NetworkItem` and `GmapsButton` to use Radix UI's `<Button asChild>` to wrap their inner links, removing invalid HTML structures (a button nested inside an anchor tag) that confuse screen readers.
- Fixed a parameter casing lint error in `GmapsButton`.

🎯 Why:
- Using semantic tags and correctly formed HTML structures is crucial for screen readers and keyboard accessibility.
- The `asChild` prop on Shadcn UI/Radix components is a highly effective way to apply component styles to native routing tags (like TanStack `<Link>` or `<a>`) without generating deeply nested or invalid HTML.

♿ Accessibility:
- Restored keyboard focus traversal for LanguageSwitcher.
- Improved ARIA structure for buttons acting as links.

Co-authored-by: Twinber <5513621+Twinber@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant