Fix memory usage and chunkcache by Trainboy15 · Pull Request #18 · TuffNetwork/TuffXPlus

Trainboy15 · 2026-05-18T13:59:02Z

IDK if it works put it compiled so...

Also u might want to add back the deploy to testers repo, but i had to remove it

Removed deployment step to Testers Repo from workflow.

Trainboy15 · 2026-05-18T16:54:59Z

@UplandJacob If you could test the TuffXPlus-1.0.0-patch that would be great

bobhenl · 2026-05-18T18:59:58Z

Still seems to be a bit crazy @Trainboy15

maybe resetting cache more often or not saving so many things to it?
https://spark.lucko.me/JKyN8ssn5p

Trainboy15 · 2026-05-18T20:35:28Z

I agree, it prob shouldent use 24GB, but it seems at least a bit better than 36GB

Add fixes

bobhenl · 2026-05-19T14:26:17Z

[13:12:19] [Server thread/INFO]: [TuffXPlus] Enabling TuffXPlus v1.0.0-patch
[13:12:19] [Server thread/INFO]: [TuffXPlus] [Y0] Server Minecraft Version: 1.21.11
[13:12:19] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] Generating ViaBlocks Pre-Defined Palette...
[13:12:19] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] Palette initialized with 649 entries.
[13:12:19] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] Paper detected. Enabling optimized asynchronous scheduling.
[13:12:19] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] ViaBlocks has been enabled successfully and is listening for client handshakes.
[13:12:19] [Server thread/INFO]: [TuffXPlus] [ViaEntities] ViaEntities enabled with 43 modern entities
[13:12:19] [Server thread/INFO]: [TuffXPlus] [TuffActions] Successfully loaded 1326 creative tab mappings.
[13:12:19] [Server thread/INFO]: [TuffXPlus] [TuffActions] TuffActions has been enabled
[13:12:19] [Server thread/INFO]: [TuffXPlus] [TuffActions] Enabling features...
[13:12:19] [Server thread/INFO]: [TuffXPlus] [TuffActions] Swimming enabled.
[13:12:19] [Server thread/INFO]: [TuffXPlus] [TuffActions] Creative Items enabled.
[13:12:19] [Server thread/INFO]: [TuffXPlus] [TuffActions] Finished enabling features.
[13:12:19] [Server thread/ERROR]: Error occurred while enabling TuffXPlus v1.0.0-patch (Is it up to date?)
java.lang.IllegalArgumentException: This registration already exists
	at org.bukkit.plugin.messaging.StandardMessenger.addToIncoming(StandardMessenger.java:96) ~[leaf-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.messaging.StandardMessenger.registerIncomingPluginChannel(StandardMessenger.java:228) ~[leaf-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at TuffXPlus-1.0.0-patch.jar//tf.tuff.TuffX.onEnable(TuffX.java:87) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[leaf-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:207) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:519) ~[leaf-api-1.21.11-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:658) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:615) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.initPostWorld(MinecraftServer.java:690) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:426) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1330) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:430) ~[leaf-1.21.11.jar:1.21.11-144-d0ed97c]
	at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]
[13:12:19] [Server thread/INFO]: [TuffXPlus] Disabling TuffXPlus v1.0.0-patch
[13:12:19] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] ViaBlocks has been disabled.

Trainboy15 · 2026-05-19T15:36:31Z

Yes, I know I'm still trying to fix

…

Sent from my Apple Watch

Trainboy15 · 2026-05-19T15:54:45Z

K it should be fixed... use the latest bulid after it gets done

Trainboy15 · 2026-05-19T16:08:21Z

@bobhenl If you could test it now that would be great

bobhenl · 2026-05-19T16:11:14Z

where can be the build downloaded btw, I don't see it in actions

Trainboy15 · 2026-05-19T16:31:08Z

@bobhenl https://github.com/Trainboy15/TuffXPlus/blob/main/builds/TuffXPlus-1.0.0-patch.jar

Trainboy15 · 2026-05-19T17:07:40Z

Download here @bobhenl

Removed redundant job configuration for unit tests and updated the path for uploading test reports.

bobhenl · 2026-05-20T12:38:03Z

💀 https://spark.lucko.me/vCOcRA41ge https://spark.lucko.me/q9XEYH12qu

Trainboy15 · 2026-05-20T14:09:38Z

💀, I might have fixed it, let me know

UplandJacob

Looks good so far! I've really needed to do a pass like this for a while but haven't had the time, so thanks for the help. I know this PR is still a draft, but I have some random comments to think about:

Make sure you're not adding any new trailing whitespace. I've got some cleanup to do, but I don't need more 😭.
Please don't mess with the feature loading in this PR since that involves a bunch more work to make sure everything can be reloaded.
Please make a separate PR for the update detector. It looks good; I just can't comment on both at the same time.

I really like having some tests in our workflow; that will be nice for validation.

UplandJacob · 2026-05-21T04:11:29Z

    }

    public void setChunkInjector(tf.tuff.netty.ChunkInjector injector) {
+        if (injector == null) {


Since it's just a single null check, the return in a single line without a block will look cleaner. I'm trying to standardize this in our codebase, so it would be great if you could do it everywhere.

UplandJacob · 2026-05-21T04:18:20Z

bobhenl · 2026-05-21T11:50:05Z

https://spark.lucko.me/ZF1ev0euUM seems to be better, but maybe ifit can be even more it would be good

bobhenl · 2026-05-22T20:16:24Z

btw is it checking just eagler players? https://spark.lucko.me/pvGBrzMdbI

https://spark.lucko.me/CfTf6fEcPk

Trainboy15 · 2026-05-23T07:42:42Z

Not sure 100%. will look into it

UplandJacob · 2026-05-22T20:28:48Z

    }

    public void setChunkInjector(tf.tuff.netty.ChunkInjector injector) {
+        if (injector == null) { return; }


Suggested change

if (injector == null) { return; }

if (injector == null) return;

This is what the meant. It literally doesn’t need a block at all.

UplandJacob · 2026-05-23T16:59:49Z

    private ChunkInjector chunkInjector;
+    private static final String CURRENT_VERSION = "1.0.0-patch";
+    private static final String BUILDS_API_URL = "https://api.github.com/repos/Trainboy15/TuffXPlus/contents/builds";
+


You've still got a lot of update checker things here that should be in a new PR

UplandJacob · 2026-05-23T17:00:19Z

        return true;
    }

+


UplandJacob · 2026-05-23T17:00:26Z

    @EventHandler(priority = EventPriority.MONITOR)
    public void onPlayerJoin(PlayerJoinEvent e) {
        y0Plugin.handlePlayerJoin(e);
+


UplandJacob · 2026-05-23T17:08:52Z

Because you've made this PR from your main branch, the Action keeps updating the builds. You should really create a separate branch to make this PR from.

Trainboy15 and others added 7 commits May 18, 2026 09:30

Optomize memory usage and cache usage

d6b2c05

Update version from 1.0.1-beta to 1.0.0-patch

6952825

Remove gradle temp

743151f

Refactor Gradle CI workflow for improved structure

0a82893

Update build artifact

f499758

Remove deployment step from gradle.yml

ecedd55

Removed deployment step to Testers Repo from workflow.

Update build artifact

35d2da4

Trainboy15 added 2 commits May 18, 2026 16:36

Fix config

52ea90c

Add NPE catches

bcfb2b9

Trainboy15 marked this pull request as draft May 18, 2026 20:45

Trainboy15 and others added 6 commits May 18, 2026 16:47

Merge pull request #1 from Trainboy15/testing

a632e1f

Add fixes

Update build artifact

e6d7ee9

Tab indentation

cd5988f

Update build artifact

5b1cae7

Clean up whitespace

abb5169

Update build artifact

ab3107e

Fix IllegalArgumentException

b64bd0d

Update build artifact

d5d0b4c

Trainboy15 and others added 3 commits May 19, 2026 12:25

Add update check

d7da218

Fixed update checker

c327678

Update build artifact

854f750

Trainboy15 and others added 7 commits May 19, 2026 13:11

Add testing... IDK if it will work

951fab7

Change to java 17

ddd22ad

Fix dependencies?

c97efac

FR this time trust

8005e8f

Update build artifact

509cf1b

Refactor GitHub Actions workflow for tests

2967f45

Removed redundant job configuration for unit tests and updated the path for uploading test reports.

Update build artifact

21ac55b

Trainboy15 and others added 2 commits May 20, 2026 10:08

maybe fix memory issuses

acf5f53

Update build artifact

b2a43a6

UplandJacob mentioned this pull request May 21, 2026

memory consumed #17

Open

UplandJacob requested changes May 21, 2026

View reviewed changes

Trainboy15 and others added 2 commits May 21, 2026 13:04

Impement @UplandJacob's changes

707b3cf

Update build artifact

844dbd9

Trainboy15 marked this pull request as ready for review May 21, 2026 17:17

UplandJacob and others added 6 commits May 23, 2026 12:02

undo some things for now

9cc2862

Update build artifact

c23163c

oop more

e5c2f5f

Update build artifact

fe9c89c

Remove unnecessary line from gradle.yml

6427b1e

Update build artifact

fb46122

UplandJacob requested changes May 23, 2026

View reviewed changes

	if (injector == null) { return; }
	if (injector == null) return;

Conversation

Trainboy15 commented May 18, 2026

Uh oh!

Trainboy15 commented May 18, 2026

Uh oh!

bobhenl commented May 18, 2026

Uh oh!

Trainboy15 commented May 18, 2026

Uh oh!

bobhenl commented May 19, 2026

Uh oh!

Trainboy15 commented May 19, 2026 via email

Uh oh!

Trainboy15 commented May 19, 2026

Uh oh!

Trainboy15 commented May 19, 2026

Uh oh!

bobhenl commented May 19, 2026

Uh oh!

Trainboy15 commented May 19, 2026

Uh oh!

Trainboy15 commented May 19, 2026

Uh oh!

bobhenl commented May 20, 2026

Uh oh!

Trainboy15 commented May 20, 2026

Uh oh!

UplandJacob left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

UplandJacob May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UplandJacob May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bobhenl commented May 21, 2026

Uh oh!

bobhenl commented May 22, 2026

Uh oh!

Trainboy15 commented May 23, 2026

Uh oh!

UplandJacob May 22, 2026

Choose a reason for hiding this comment

Uh oh!

UplandJacob May 23, 2026

Choose a reason for hiding this comment

Uh oh!

UplandJacob May 23, 2026

Choose a reason for hiding this comment

Uh oh!

UplandJacob May 23, 2026

Choose a reason for hiding this comment

Uh oh!

UplandJacob May 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants