memory consumed

[bobhenl]

Hello, plugin seems to consume so much memory https://spark.lucko.me/YyFwXk1Cf8

[bobhenl]

Also via blocks are used even when disabled

https://spark.lucko.me/UJqNDeXm0J

and y0 also consumes a bit of ram

``` viablocks: viablocks-enabled: false ``` 💀 and memory is growing to GBs https://spark.lucko.me/u2140ZBEZs

[ProJakob]

this clearly works as intended 👍

[bobhenl]

I don’t think it should consume so much memory, cannot we limit it?

[Trainboy15]

Sounds like a memory leak...

[bobhenl]

Based on the first spark provided memory consumption is the highest of all plugins

https://spark.lucko.me/YyFwXk1Cf8 I don't think that's intended

[Trainboy15]

Seems like the 2 biggest culprits are TuffXPlus/src/main/java/tf/tuff/y0
/Y0Plugin.java:691 or the csp function and TuffXPlus/src/main/java/tf/tuff/viablocks/CustomBlockListener.java:260 or the findModernBlocksInChunk function

[Trainboy15]

findModernBlocksInChunk is a method used in chunk caching and building chunk packets

[Trainboy15]

Just made a PR about it, might have fixed but idk

[bobhenl]

I'll test that PR thanks.

And btw when the viablocks is disabled, it still enables it:

[17:12:37] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] Generating ViaBlocks Pre-Defined Palette...
[17:12:37] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] Palette initialized with 649 entries.
[17:12:37] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] Paper detected. Enabling optimized asynchronous scheduling.
[17:12:37] [Server thread/INFO]: [TuffXPlus] [ViaBlocks] ViaBlocks has been enabled successfully and is listening for client handshakes.

I guess similar is for Y0

[Trainboy15]

i might be able to fix that... also can you try the one i made? @bobhenl

[bobhenl]

Replied there, not sure if you see replies there

[UplandJacob]

#18 should help with this