Skip to content

Comments

Added member cancellation reason header#26542

Merged
weylandswart merged 3 commits intomainfrom
member-cancelation-email-header
Feb 24, 2026
Merged

Added member cancellation reason header#26542
weylandswart merged 3 commits intomainfrom
member-cancelation-email-header

Conversation

@weylandswart
Copy link
Contributor

@weylandswart weylandswart commented Feb 23, 2026

Ref https://linear.app/ghost/issue/DES-1296/cancellation-email-missing-styling-for-cancellation-reason

We had previously removed the cancellation reason heading. This adds it back.

image

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

Walkthrough

Updated the paid subscription cancellation email template to change inline labels: "Name" and "Tier" are now bold without trailing colons; "Expired on" and "Expires on" are bold without trailing colons and their corresponding value font-weight was reduced. The cancellationReason block now includes a bold "Cancellation reason" label followed by the quoted reason when present. Unit tests were updated to assert the new "Cancellation reason" label and to separately check the reason text; conditional visibility of the cancellation block was not changed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change in the pull request: adding back the cancellation reason header styling that was previously removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description directly relates to the changeset, referencing a specific issue (DES-1296) and explaining the purpose of adding back the cancellation reason heading.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch member-cancelation-email-header

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs (1)

19-23: Consider updating the preview text label for consistency.

The preview snippet (shown in email clients before opening) still reads Reason: while the email body now uses Cancellation reason:. The label mismatch is cosmetic but noticeable.

✏️ Suggested update
-  Reason: {{subscriptionData.cancellationReason}}
+  Cancellation reason: {{subscriptionData.cancellationReason}}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs`
around lines 19 - 23, The preview text label in the new-paid-cancellation
template is inconsistent: update the preview snippet that conditionally renders
subscriptionData.cancellationReason so the label matches the email body by
replacing "Reason:" with "Cancellation reason:" (locate the conditional block
using subscriptionData.cancellationReason in new-paid-cancellation.hbs and
change the preview label to "Cancellation reason:" to ensure consistency).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs`:
- Around line 19-23: The preview text label in the new-paid-cancellation
template is inconsistent: update the preview snippet that conditionally renders
subscriptionData.cancellationReason so the label matches the email body by
replacing "Reason:" with "Cancellation reason:" (locate the conditional block
using subscriptionData.cancellationReason in new-paid-cancellation.hbs and
change the preview label to "Cancellation reason:" to ensure consistency).

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3472e54 and 85fc37e.

📒 Files selected for processing (2)
  • ghost/core/core/server/services/staff/email-templates/new-paid-cancellation.hbs
  • ghost/core/test/unit/server/services/staff/staff-service.test.js

@weylandswart weylandswart merged commit 2920f92 into main Feb 24, 2026
63 of 65 checks passed
@weylandswart weylandswart deleted the member-cancelation-email-header branch February 24, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant